Allow storage different from CDN to be tested by RegistrationComparer #749
Conversation
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
skofman1,
dannyjdev and
zhhyu
joelverhagen
force-pushed
the
jver-cmp
branch
from
2a775aa to
b39a78c
Compare
| .SelectMany(x => x) | ||
| .Concat(leafUrlGroups.SelectMany(x => x))); | ||
| .Concat(leafUrlGroups.SelectMany(x => x)) | ||
| .Select(x => new KeyValuePair<string, HiveConfiguration>(x.Url, x.Hive))); |
There was a problem hiding this comment.
KeyValuePair.Create(x.Url, x.Hive) would be a bit more compact.
What is Url here, by the way? Is it just to be able to throw exception in GetJObjectOrNullAsync? If yes, given that it is a private method, can we validate data earlier?
There was a problem hiding this comment.
This is the official (not blob storage) URL of a registration leaf that needs to be downloaded and validated.
There was a problem hiding this comment.
The URL is there so we can parallelize the downloads of many leaves and pages.
I'll use the KeyValuePair.Create trick.
There was a problem hiding this comment.
Oh, it does not exist for .NET Framework :(
https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.keyvaluepair.create?view=netcore-3.1&viewFallbackFrom=netframework-4.7.2
|
No need to update the test coverage? |
This is a validation job for the one-time transition from old registration to new registration impl. I did not write unit tests for this level. |
Improved logging around HTTP requests.
Removed duplicate HTTP request (OMG).
Moved response body fetching into HttpClient.GetAsync so HttpClient.Timeout acts on it.
Right now, this job can only test China storage if it's running from China. This change enables hitting storage that doesn't sit behind the client's resolution of api.nuget.org.
Related to NuGet/NuGetGallery#7741.